Ok, that big mess of patches boils down to two key test cases:
1. File > Open's progress dialog.
2. Progress dialog when adding audio files to the Audio File Manager.
Specific improvements for the release notes:
1. File > Open's Cancel button now works without crashing.
2. Audio File Manager "Add Audio File" progress dialog now has a Cancel
button that works.
The only minor "regression" is that the native Qt QProgressDialog
doesn't always stay hidden for the first 4 seconds. E.g. it pops up
when we change the label text, and it has to be forced up in
indeterminate mode or it never comes up at all. I'm guessing Qt will
eventually address these issues and they will go away. I've only tested
with Qt 4. They may already be gone.
So, dust off your oldest/slowest machine (not too old) and try
loading up some huge .rg files with huge audio files. Then try adding
huge audio files via the Audio File Manager.
> So, dust off your oldest/slowest machine (not too old) and try
> loading up some huge .rg files with huge audio files. Then try adding
> huge audio files via the Audio File Manager.
Tried Qt4 and Qt5. Considering that the progress dialog does something
sensible looking and helpful now, the delay in showing it feels a bit
too long. I had to get to a positively gigantic (10,000 measures, many
large audio files, thousands of segments) file to load it in more than x
seconds (I think x == 4 but subjectively it feels more like x == 7).
In the real world, it's probably fine. I'll never see a progress
dialog, because none of my real stuff takes more than x seconds to load.
If I do see a progress dialog, the count-down goes along at a sensible
rate, the appearance is satisfying, and the cancel button works.
All in all, clearly a marked improvement, and a fine 11th hour addition
to this release.
There are some style-related issues in Qt5 on KDE5 that I need to
address. I would like to get this done before the release, but my
employer is forcing me to work six days a week until I can arrange to
secure different employment and tell these people where to stick their job.